* Present:
+ Sophie, Caolan, Cloph, Heiko, Ilmari, Lubos, Olivier, Xisco, Stephan, Miklos, Hossein, Kendy, Eike, Michael S, Thorsten
* Completed Action Items:
+ create the ranking sheet for under-loved areas (Miklos)
+ pass on LOOL atticization proposal to board (Stephan)
* Pending Action Items:
+ None
* Release Engineering update (Cloph)
+ 7.4 status: beta1 is on the mirrors, string/UI freeze in 3 weeks
+ including Windows arm64 builds
+ fixed download filename problems
+ so that you can differentiate between arm64 vs x86_64
+ some Writer-related issues were reported (but not Calc)
+ can do a beta2 next week if wanted (not planning currently)
+ rc1 in 3 weeks
+ 7.3 status: 7.3.5 rc1 in 2 weeks
+ tinderbox for Android viewer builds was offline, now back
+ App store status? (Caolan)
+ have accounts setup, will try to upload a first binary (Cloph)
+ in progress
+ going to setup bibisect repos for master (Xisco)
+ next version? 7.5 vs 8.0?
+ some larger change always happened at the same time (Cloph)
AI: + will ask Italo (Xisco)
* Documentation (Olivier)
+ New Help - no news
+ Helpcontent2
+ Updates and fixes (M. Kaganski, S. Chaiklin, ohallot, D. Schulten, Adolfo B)
+ Scriptforge Help pages (R. Lima)
+ Extended tips
+ updates from translations review (ohallot)
+ Guides
+ work in progress
+ question about extended tips
+ always get -1 from Jenkins on gerrit for core.git changes
+ how to avoid that?
+ there was a problem with master with one of the changes, reverted by Xisco (Cloph)
+ also some Windows boxes failing in sc_macros
+ solution is to hit "resume" on the failing platform
+ please don't override it as a habit
+ looked at what could be the root cause of sc_macros failures (Cloph)
+ multiple machines failed, but reboot helped
+ Bugzilla Documentation statistics
245(245) bugs open
+ Updates:
BZ changes 1 week 1 month 3 months 12 months
created 10(-1) 48(-5) 120(-3) 325(-9)
commented 6(-3) 139(-8) 292(-14) 1468(-23)
resolved 0(-1) 8(-3) 57(0) 199(-9)
+ top 10 contributors:
Seth Chaiklin made 114 changes in 1 month, and 289 changes in 1 year
Heiko Tietze made 23 changes in 1 month, and 111 changes in 1 year
Timur made 22 changes in 1 month, and 22 changes in 1 year
Olivier Hallot made 20 changes in 1 month, and 445 changes in 1 year
Kaganski, Mike made 11 changes in 1 month, and 93 changes in 1 year
Ilmari Lauhakangas made 9 changes in 1 month, and 110 changes in 1 year
Rafael Lima made 8 changes in 1 month, and 312 changes in 1 year
Henschel, Regina made 7 changes in 1 month, and 26 changes in 1 year
McNamara, Caolán made 6 changes in 1 month, and 15 changes in 1 year
Dieter made 6 changes in 1 month, and 98 changes in 1 year
* UX Update (Heiko)
+ Bugzilla (topicUI) statistics
273(273) (topicUI) bugs open, 76(76) (needsUXEval) needs to be evaluated by the UXteam
+ Updates:
BZ changes 1 week 1 month 3 months 12 months
added 3(-5) 8(-6) 28(-5) 55(-5)
commented 32(-48) 237(-59) 659(-73) 2514(-75)
removed 0(0) 0(-1) 12(0) 32(-3)
resolved 8(2) 31(2) 74(-3) 344(-9)
+ top 10 contributors:
Heiko Tietze made 133 changes in 1 month, and 1754 changes in 1 year
Seth Chaiklin made 37 changes in 1 month, and 194 changes in 1 year
Rafael Lima made 34 changes in 1 month, and 79 changes in 1 year
Ilmari Lauhakangas made 27 changes in 1 month, and 268 changes in 1 year
Timur made 24 changes in 1 month, and 37 changes in 1 year
Hans-Werner made 21 changes in 1 month, and 21 changes in 1 year
Németh, László made 19 changes in 1 month, and 35 changes in 1 year
Dieter made 18 changes in 1 month, and 228 changes in 1 year
Henschel, Regina made 15 changes in 1 month, and 67 changes in 1 year
Eyal Rozenberg made 13 changes in 1 month, and 94 changes in 1 year
+ [Bug 149576] Dashed bounding box/border for text not shown, when not
selected or multiple selected (Draw, Impress,...)
+ [Bug 149341] When clicking an Insert-shape button, focus is wrong
+ [Bug 149566] picture scaling problem
-> + [Bug 149306] Problem with decimal number selection using double click
+ have a break iterator for words, uses mostly icu internally (Eike)
+ not sure though if double-clicking something actually uses that
+ UI: Improve handling of configuring table borders in table properties
dialog (to make it work for multiple workflows)
+ https://bugs.documentfoundation.org/show_bug.cgi?id=143249
+ mockup attached to ticket
+ Add the ability to bookmark or comment spelling/grammar mistakes
in text from spellcheck dialog
+ https://bugs.documentfoundation.org/show_bug.cgi?id=93073
+ mockup attached to ticket
* Crash Testing (Caolan)
+ 148(+144) import failure, 62(+60) export failures
- includes xisco's forum documents. 238162 files in total now
- some new documents are reproducers for frequent crashreport signatures
+ 5 coverity issues
+ 8 ossfuzz issues
* Crash Reporting (Xisco)
+ https://crashreport.libreoffice.org/stats/version/7.2.7.2
+ (+14) 396 382 314 268 167 0
+ https://crashreport.libreoffice.org/stats/version/7.3.3.2
+ (-359) 1438 1797 1583 1417 1055 555 0
+ https://crashreport.libreoffice.org/stats/version/7.3.4.2
+ (+675) 675 0
Some of the crashes fixed in 7.3.4:
- vcl::unohelper::DragAndDropWrapper::dragGestureRecognized(com::sun::star::datatransfer::dnd::DragGestureEvent const &)
- Thanks to unknown
- SwBookmarkPortion::DoPaint(SwTextPaintInfo const &,rtl::OUString &,SwFont &,int &)
- Thanks to Xisco
- EditLine::CalcTextSize(ParaPortion &)
- Thanks to Caolán
- dp_gui::TheExtensionManager::modified(com::sun::star::lang::EventObject const &)
- Thanks to Caolán
- sw::sidebar::WriterInspectorTextPanel::WriterInspectorTextPanel(weld::Widget *)
- Thanks to Caolán
- DocxAttributeOutput::WriteCollectedRunProperties()
- Thanks to Stephan
- SdrUndoGeoObj::Undo()
- Thanks to unknown
* Mentoring/EasyHack update (Hossein)
committer... 1 week 1 month 3 months 12 months
open 101(41) 180(42) 182(44) 182(44)
reviews 302(-8) 1146(52) 2942(-12) 12572(-14)
merged 280(16) 1295(-11) 3604(-54) 15578(-56)
abandoned 16(10) 58(-1) 303(7) 823(7)
own commits 196(1) 935(-74) 2760(-54) 12311(-104)
review commits 40(-1) 177(-13) 581(-11) 3560(-42)
contributor... 1 week 1 month 3 months 12 months
open 40(7) 91(10) 98(-3) 98(-3)
reviews 802(132) 3062(18) 8556(-24) 34246(-80)
merged 6(3) 34(-2) 138(-5) 1337(-20)
abandoned 9(8) 41(-2) 194(5) 458(6)
own commits 9(1) 46(-3) 172(3) 1344(-11)
review commits 0(0) 0(0) 0(0) 0(0)
+ easyHack statistics:
needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 305(305)
total 364(364) assigned 15(15) open 322(322)
+ top 10 contributors:
Srebotnjak, Martin made 6 patches in 1 month, and 20 patches in 1 year
Goncharuk, Lera made 5 patches in 1 month, and 5 patches in 1 year
Nagy Tibor made 4 patches in 1 month, and 32 patches in 1 year
Attila Bakos made 4 patches in 1 month, and 35 patches in 1 year
Paris Oplopoios made 3 patches in 1 month, and 12 patches in 1 year
Marco Pinto made 2 patches in 1 month, and 7 patches in 1 year
Ashleigh Sinclair made 2 patches in 1 month, and 2 patches in 1 year
Dietrich Schulten made 2 patches in 1 month, and 2 patches in 1 year
Possoz, Louis made 1 patches in 1 month, and 1 patches in 1 year
Attila Szűcs made 1 patches in 1 month, and 13 patches in 1 year
+ top 10 reviewers:
Thorsten Behrens made 96 review comments in 1 month, and 832 in 1 year
McNamara, Caolán made 92 review comments in 1 month, and 548 in 1 year
Xisco Fauli made 86 review comments in 1 month, and 908 in 1 year
Michael Stahl made 82 review comments in 1 month, and 1234 in 1 year
Adolfo Jayme Barrientos made 68 review comments in 1 month, and 974 in 1 year
Kaganski, Mike made 52 review comments in 1 month, and 710 in 1 year
Nabet, Julien made 50 review comments in 1 month, and 626 in 1 year
Vajna, Miklos made 50 review comments in 1 month, and 626 in 1 year
Christian Lohmaier made 46 review comments in 1 month, and 254 in 1 year
Németh, László made 44 review comments in 1 month, and 428 in 1 year
+ Patches automatically abandoned:
tdf#146150 Use dispatch command instead of numerical ID for the UNO commands ( Vaibhav Malik ) -> Restored again
- https://gerrit.libreoffice.org/#/c/128801
WIP WindowsKillWrapper ( Noel Grandin )
- https://gerrit.libreoffice.org/#/c/129675
tdf#137855: sw: move UItest to CppUnittest ( Xisco Fauli )
- https://gerrit.libreoffice.org/#/c/129777
add vcl::ScopedMapMode and use that in ScGridWindow overlay code ( Tomaž Vajngerl )
- https://gerrit.libreoffice.org/#/c/132720
-> These are duplicates, and are not important ↓
tdf#143148 Use pragma once instead of include guards ( Shady Mohamed )
- https://gerrit.libreoffice.org/#/c/132797
tdf#143148 Use pragma once instead of include guards ( Shady Mohamed )
- https://gerrit.libreoffice.org/#/c/132798
tdf#143148 Use pragma once instead of include guards ( Shady Mohamed )
- https://gerrit.libreoffice.org/#/c/132799
tdf#143148 Use pragma once instead of include guards ( Shady Mohamed )
- https://gerrit.libreoffice.org/#/c/132800
tdf#143148 Use pragma once instead of include guards ( Shady Mohamed )
- https://gerrit.libreoffice.org/#/c/132803
tdf#143148 Use pragma once instead of include guards ( Shady Mohamed )
- https://gerrit.libreoffice.org/#/c/132850
+ big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
Dietrich Schulten (escalon.de)
خالد حسني khaled (aliftype.com) <-- Khaled Hosny new email address I think
Lukas Molleman
+ Reviewed some EasyHacks including some old ones
+ ~20 processed, 15 still relevant, 334 to go
+ help is still appreciated with this
+ Preparing for the Amirkabir university hackfest
+ Created a VM for the hackfest (based on Virtualbox)
+ Linux (Windows would also be possible)
+ Added neeede tools, IDEs, prebuilt the LibreOffice
+ Good for a fast start
+ will talk to Cloph wrt old VMs we had for hackfests
+ Providing built core folder + ccache for different platforms
+ do you consider an icecream farm? (Kendy)
+ https://github.com/icecc/icecream
+ can be combined with ccache
+ brings much faster build times if there are enough people on the same LAN
* GSoC (Hossein/Ilmari)
+ Timeline: https://developers.google.com/open-source/gsoc/timeline
+ coding perid has officially started
* Commit Access
+ None
* Developer Certification (Stephan/Kendy/Thorsten/László)
+ resting since: 23 weeks (limit: 20 weeks)
* Jenkins / CI update (Cloph)
from:Thu Jun 9 13:55:48 2022
master linux rel jobs: 118 ok: 118 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
master linux dbg jobs: 97 ok: 91 ko: 6 fail ratio: 6.19 % break: 6 broken duration:10.90%
master mac rel jobs: 53 ok: 53 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
master mac dbg jobs: 54 ok: 54 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
master win rel jobs: 68 ok: 68 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
master win dbg jobs: 72 ok: 70 ko: 1 fail ratio: 1.39 % break: 1 broken duration: 0.34%
master win64 dbg jobs: 68 ok: 67 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
master gerrit lin jobs: 606 ok: 535 ko: 46 fail ratio: 7.59% time for ok: mean: 21 median: 18
master gerrit plg jobs: 503 ok: 381 ko: 92 fail ratio: 18.29% time for ok: mean: 43 median: 42
master gerrit win jobs: 722 ok: 375 ko: 304 fail ratio: 42.11% time for ok: mean: 62 median: 56
master gerrit mac jobs: 613 ok: 505 ko: 67 fail ratio: 10.93% time for ok: mean: 38 median: 34
master android jobs: 497 ok: 436 ko: 29 fail ratio: 5.84% time for ok: mean: 31 median: 20
master gerrit all jobs: 594 ok: 231 ko: 317 fail ratio: 53.37% time for ok: mean: 134 median: 131
+ https://dev-www.libreoffice.org/tmp/gerrit_220616.html
+ tests that failed more than twice in last seven days
3 CppunitTest_dbaccess_firebird_test gerrit_windows
3 CppunitTest_sc_subsequent_export_test gerrit_windows
3 CppunitTest_sd_import_tests2 gerrit_linux_gcc_release
3 CppunitTest_vcl_backend_test gerrit_windows
4 Killed by the kill-wrapper gerrit_linux_clang_dbgutil_branch
4 CppunitTest_sc_vba_macro_test gerrit_windows
4 CppunitTest_sdext_pdfimport gerrit_windows
5 CppunitTest_sc_subsequent_export_test2 gerrit_windows
5 CppunitTest_sw_uiwriter6 gerrit_windows
5 UITest_calc_tests8 gerrit_linux_clang_dbgutil
6 Killed by the kill-wrapper gerrit_linux_clang_dbgutil
6 CppunitTest_sw_core_draw gerrit_mac
6 CppunitTest_sw_uiwriter6 gerrit_mac
7 UITest_impress_tests gerrit_linux_clang_dbgutil
39 CppunitTest_sw_core_draw gerrit_windows
118 CppunitTest_sc_macros_test gerrit_windows
+ sc_macros_test: unknown issue with bots, no leftover processes, nothing blocking/nothing extraordinary, reboot fixed it (Fri-Mon)
+ sw_core_draw started with merge of a patch (Tue), reverted currently
https://gerrit.libreoffice.org/c/core/+/135859
+ see above in the documentation question
+ sc_macros_test on Windows failed without a reason from Friday on Monday
+ and then a languagetool config change passed CI once, but then caused sw_core_draw failures regularly
+ Xisco reverted the change for now
* l10n (Sophie)
* work is going on, no issue to report
* What’s cooking (Miklos)
+ 16k cols in Calc (Lubos): https://bugs.documentfoundation.org/show_bug.cgi?id=133764
+ feature/chartdatatable: MSO-style data tables for charts (Tomaz): see initial commits in master
+ dynamic diagram project status? (Heiko)
+ not experimental currently and not fully done
+ Xisco changed the UI to experimental yesterday, for now (Thorsten)
* Down-stream projects in the bugzilla (Kendy)
+ any concerns with the existing setup?
+ there was some concern on board-discuss@
+ in most cases we have a nicely fit subproject in bugzilla
+ any components missing?
+ wanted to double-check with the ESC if this is still OK technically
+ any changes wanted?
+ don't mind having them (Cloph)
+ the problem started when some Collabora Online reports were reported in bugzilla (Xisco)
+ the problem was not Collabora Online (Kendy)
+ no question about that, such shouldn't be in the TDF bugzilla, there is a github issue tracker for that
+ it was Collabora Office in mac app store
+ no problem with that (Xisco)
+ if it doesn't appear in LO itself, that would be different (Kendy)
+ if a Collabora Office customer reports a bug, does Collabora enourage people to report bugs in the TDF bugzilla? (Olivier)
+ no, please report such cases to us (Kendy)
+ in many cases our tickets have a matching TDF bugreport
+ intention is to be as open as possible
+ regularly doing that, too (Thorsten)
+ try to have matching TDF bugreports to be opened, if possible
+ so we have a place were e.g. regressions / bibisects can happen
+ does it mean that downstream project handles bugs on their own, only LO-relevant stuff goes to TDF bugzilla? (Heiko)
+ Thorsten was talking about trying to be open: if the customer report affects LO master, then file it as a TDF bug (Michael S)
+ if people buy from app store / use distro packages, they don't have enterprise customer relationship (Michael S)
+ such an end-user may contribute by writing a quality bugreport, just happens to be on a downstream version (Thorsten)
+ e.g. in the past: there was lots of Linux distro users filing bugs
+ that mostly where not reproducible in upstream
+ but e.g. bug in Debian may have a simple LO bug -> fair upstream bugreport
+ usually I use notourbug for flatpak/snap issues that seem to be related to their sandboxing functionality or something similar (Ilmari)
+ may cause some more work if bugs can't be reproduced due to packaging differences (Thorsten)
+ understand the frustration if the bug is specific to some packaging but it's not obvious initially
+ the bugs should be reasonably marked from a downstream vendor (mac app store, Collabora, etc) (Kendy)
+ then the volunteer is free to skip such bugs
+ even if it may be relevant for LO master
+ in other words: if it only affects downstream versions, feel free to close it as NOTOURBUG (Cloph)
+ i.e. happy to hear about all bugs, and then re-assess: if it's low quality, hard-
to-reproduce bugs (e.g. coming from one particular packaging), then it's not
worth it (Thorsten)
+ this is about end-users of course, not enterprise customers (unless for
documentation)
+ agreed (all)
* LibreOffice conference (Sophie)
+ if you were volunteering to review conferenc invites, please keep in mind that the deadline was yesterday
+ where is the list to review? (Stephan)
+ the idea was to build that list as well (Sophie)
+ expecting 20 candidates and then 10 would be invited
+ deadline for talks is: July 15
https://blog.documentfoundation.org/blog/2022/05/16/libocon-2022-call-for-papers/
* QA update (Xisco)
+ UNCONFIRMED: 1689 (-10)
+ enhancements: 271 (-4)
+ needsUXEval: 5 (-3)
+ haveBackTrace: 6 (+0)
+ needsDevAdvice: 29 (+0)
+ documentation: 29 (-1)
+ android: 3 (+0)
+ iOS: 0 (+0)
+ Online: 12 (+0)
+ Most pressing bugs:
New:
None
Old:
+ macOS: Can't save or open files using Finder dialog on Standard accounts on macOS 10.15 Catalina
+ https://bugs.documentfoundation.org/show_bug.cgi?id=128233
+ started to happen with a new macOS version
+ somebody has to do the work to keep up with the new Apple requirements
+ sometimes this works, sometimes now (Stephan)
+ New high severity bugs of the week:
+ LO Calc with RadioButton Crash in: ScUnoListenerCalls::ExecuteAndClear() - steps Comment 22
+ https://bugs.documentfoundation.org/show_bug.cgi?id=147822
+ not a regression?
+ Follow URL link in Writer text when navigator displayed: Crash in: _chkstk
+ https://bugs.documentfoundation.org/show_bug.cgi?id=149467
+ Jim?
+ Writer is crashing after a label has just been created
+ https://bugs.documentfoundation.org/show_bug.cgi?id=149524
+ Julien has a patch https://gerrit.libreoffice.org/c/core/+/135675
+ patch works for me but cannot do the code review (Heiko)
+ Calc Insert Sheet + save Freeze
+ https://bugs.documentfoundation.org/show_bug.cgi?id=149529
+ Caolán has a patch https://gerrit.libreoffice.org/c/core/+/135998
+ CRASH: using empty transpose
+ https://bugs.documentfoundation.org/show_bug.cgi?id=149554
+ already fixed, thanks Lubos
* QA stats
+ https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
+90 -22 (-90) overall)
many thanks to the top bug squashers:
QA Administrators 12
Timur 11
Michael Stahl (allotropia) 9
Aron Budea 8
Julien Nabet 4
Buovjaga 3
Eike Rathke 3
Heiko Tietze 3
Mike Kaganski 3
Caolán McNamara 2
+ top 10 bugs reporters:
Xisco Faulí 10
Eyal Rozenberg 4
Regina Henschel 4
Telesto 3
phv 3
Óvári 3
Aron Budea 2
Colin 2
Dr. Matthias Weisser 2
Gabor Kelemen (allotropia) 2
+ top 10 bugs fixers:
Michael Stahl 8
Nabet, Julien 4
Aron Budea 3
Rathke, Eike 3
Hung, Mark 2
McNamara, Caolán 2
Seth Chaiklin 2
Xisco Fauli 2
Andras Timar 1
Andreas Heinisch 1
+ top 10 bugs confirmers:
Rafael Lima 13
Timur 13
Xisco Fauli 10
Dieter 8
Heiko Tietze 7
Raal 6
Nabet, Julien 5
*UNKNOWN* 4
Ilmari Lauhakangas 3
m.a.riosv 3
* Highest-Priority bugs (aka "MABs"):
+ http://bit.ly/2lJAAJI
6.0 : 1/53 - 1 % (+0)
5.4 : 0/41 - 0 % (+0)
5.3 : 0/54 - 0 % (+0)
5.2 : 0/43 - 0 % (+0)
5.1 : 1/36 - 2 % (+0)
5.0 : 0/64 - 0 % (+0)
4.4 : 0/76 - 0 % (+0)
4.3 : 0/73 - 0 % (+0)
4.2 : 2/134 - 1 % (+0)
4.1 : 3/85 - 3 % (+0)
4.0 : 2/83 - 2 % (+0)
old : 1/246 - 0 % (+0)
* Bisected bugs open: keyword 'bisected'
+ more accurate - down to a single commit.
+ http://bit.ly/2dyIfDy
+
done by:
Xisco Fauli 9
Aron Budea 4
Timur 4
Raal 3
* Bibisected bugs open: keyword 'bibisected'
+ http://bit.ly/2cSCXlS
+
done by:
Xisco Fauli 9
Aron Budea 4
Raal 3
Timur 3
* all bugs tagged with 'regression'
+ 1232(-12) bugs open of 11837(+15) total 11(+0) high prio.
done by:
Xisco Fauli 10
Aron Budea 2
Timur 2
Raal 1
Nabet, Julien 1
* ~Component count net * high severity regressions
+ http://bit.ly/1HWHb3E
Writer - 6(+0)
LibreOffice - 2(+0)
Calc - 1(+0)
Draw - 1(+0)
Impress - 1(+0)
by OS:
All - 9(+0)
Linux - 0(+0)
Mac OS X - 0(+0)
Windows - 2(+0)
* ~Component count net * all regressions
+ http://bit.ly/1BUdI8i
Writer: other - 451(-6)
Calc - 197(+0)
Impress - 120(-1)
Crashes - 63(+5)
Writer: docx filter - 60(+1)
LibreOffice - 49(+0)
UI - 45(+0)
Draw - 44(+0)
Writer: perf - 37(+0)
Borders - 35(-1)
Writer: other filter - 35(+0)
Base - 33(+0)
Chart - 26(+0)
RTL - 25(+0)
Writer: doc filter - 21(+0)
Printing and PDF export - 20(+0)
BASIC - 17(+0)
filters and storage - 15(-1)
graphics stack - 15(+0)
Formula Editor - 2(+0)
framework - 2(+0)
Linguistic - 1(+0)
sdk - 1(+0)
ESC meeting minutes: 2022-06-16
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: ESC meeting minutes: 2022-06-16
- From: Miklos Vajna <vmiklos@xxxxxxxxxxxxx>
- Date: Thu, 16 Jun 2022 16:59:45 +0200
- Cc: libreoffice-qa@xxxxxxxxxxxxxxxxxxxxx
- Prev by Date: Re: Accessing main window menus during C++ test run
- Next by Date: Re: Accessing main window menus during C++ test run
- Previous by thread: How to write OOXML attribute 'vert' of <bodyPr> element to ODF?
- Next by thread: Diane Leigh license statement
- Index(es):
 |