New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1493476:  Control flow issues  (DEADCODE)
/vcl/unx/gtk3/gtkinst.cxx: 9180 in <unnamed>::set_font(_GtkLabel *, const vcl::Font &)()


________________________________________________________________________________________________________
*** CID 1493476:  Control flow issues  (DEADCODE)
/vcl/unx/gtk3/gtkinst.cxx: 9180 in <unnamed>::set_font(_GtkLabel *, const vcl::Font &)()
9174         if (pOrigList)
9175         {
9176             // tdf#143443 remove both PANGO_ATTR_ABSOLUTE_SIZE and PANGO_ATTR_SIZE
9177             // because pango_attr_list_change(..., pango_attr_size_new...) isn't
9178             // sufficient on its own to ensure a new size sticks.
9179             PangoAttrType aFilterAttrs[] = {PANGO_ATTR_ABSOLUTE_SIZE, PANGO_ATTR_SIZE, PANGO_ATTR_INVALID};
>>>     CID 1493476:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "NULL" inside this statement: "pRemovedAttrs = (pOrigList ...".
9180             PangoAttrList* pRemovedAttrs = pOrigList ? pango_attr_list_filter(pAttrList, filter_pango_attrs, &aFilterAttrs) : nullptr;
9181             pango_attr_list_unref(pRemovedAttrs);
9182         }
9183     
9184         update_attr_list(pAttrList, rFont);
9185         gtk_label_set_attributes(pLabel, pAttrList);

** CID 1493475:    (UNCAUGHT_EXCEPT)
/usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func1<mdds::mtv::default_element_block<(int)50, rtl::OUString>>, mdds::mtv::default_trait>::~multi_type_vector()()
/usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func1<mdds::mtv::default_element_block<(int)51, sc::CellTextAttr>>, mdds::mtv::default_trait>::~multi_type_vector()()
/usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func1<mdds::mtv::default_element_block<(int)52, svl::SharedString>>, mdds::mtv::default_trait>::~multi_type_vector()()
/usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func1<mdds::mtv::noncopyable_managed_element_block<(int)55, ScPostIt>>, mdds::mtv::default_trait>::~multi_type_vector()()
/usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func1<mdds::mtv::noncopyable_managed_element_block<(int)50, SvtBroadcaster>>, mdds::mtv::default_trait>::~multi_type_vector()()
/usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<(int)52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<(int)53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<(int)54, ScFormulaCell>>, sc::CellStoreTrait>::~multi_type_vector()()


________________________________________________________________________________________________________
*** CID 1493475:    (UNCAUGHT_EXCEPT)
/usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func1<mdds::mtv::default_element_block<(int)50, rtl::OUString>>, mdds::mtv::default_trait>::~multi_type_vector()()
384             abort();
385         }
386     #endif
387     }
388     
389     template<typename ElemBlockFunc, typename Trait>
>>>     CID 1493475:    (UNCAUGHT_EXCEPT)
>>>     An exception of type "mdds::general_error" is thrown but the throw list "noexcept" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
390     multi_type_vector<ElemBlockFunc, Trait>::~multi_type_vector()
391     {
392         delete_element_blocks(0, m_block_store.positions.size());
393     }
394     
395     template<typename ElemBlockFunc, typename Trait>
/usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func1<mdds::mtv::default_element_block<(int)51, sc::CellTextAttr>>, mdds::mtv::default_trait>::~multi_type_vector()()
384             abort();
385         }
386     #endif
387     }
388     
389     template<typename ElemBlockFunc, typename Trait>
>>>     CID 1493475:    (UNCAUGHT_EXCEPT)
>>>     An exception of type "mdds::general_error" is thrown but the throw list "noexcept" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
390     multi_type_vector<ElemBlockFunc, Trait>::~multi_type_vector()
391     {
392         delete_element_blocks(0, m_block_store.positions.size());
393     }
394     
395     template<typename ElemBlockFunc, typename Trait>
/usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func1<mdds::mtv::default_element_block<(int)52, svl::SharedString>>, mdds::mtv::default_trait>::~multi_type_vector()()
384             abort();
385         }
386     #endif
387     }
388     
389     template<typename ElemBlockFunc, typename Trait>
>>>     CID 1493475:    (UNCAUGHT_EXCEPT)
>>>     An exception of type "mdds::general_error" is thrown but the throw list "noexcept" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
390     multi_type_vector<ElemBlockFunc, Trait>::~multi_type_vector()
391     {
392         delete_element_blocks(0, m_block_store.positions.size());
393     }
394     
395     template<typename ElemBlockFunc, typename Trait>
/usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func1<mdds::mtv::noncopyable_managed_element_block<(int)55, ScPostIt>>, mdds::mtv::default_trait>::~multi_type_vector()()
384             abort();
385         }
386     #endif
387     }
388     
389     template<typename ElemBlockFunc, typename Trait>
>>>     CID 1493475:    (UNCAUGHT_EXCEPT)
>>>     An exception of type "mdds::general_error" is thrown but the throw list "noexcept" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
390     multi_type_vector<ElemBlockFunc, Trait>::~multi_type_vector()
391     {
392         delete_element_blocks(0, m_block_store.positions.size());
393     }
394     
395     template<typename ElemBlockFunc, typename Trait>
/usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func1<mdds::mtv::noncopyable_managed_element_block<(int)50, SvtBroadcaster>>, mdds::mtv::default_trait>::~multi_type_vector()()
384             abort();
385         }
386     #endif
387     }
388     
389     template<typename ElemBlockFunc, typename Trait>
>>>     CID 1493475:    (UNCAUGHT_EXCEPT)
>>>     An exception of type "mdds::general_error" is thrown but the throw list "noexcept" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
390     multi_type_vector<ElemBlockFunc, Trait>::~multi_type_vector()
391     {
392         delete_element_blocks(0, m_block_store.positions.size());
393     }
394     
395     template<typename ElemBlockFunc, typename Trait>
/usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<(int)52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<(int)53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<(int)54, ScFormulaCell>>, sc::CellStoreTrait>::~multi_type_vector()()
384             abort();
385         }
386     #endif
387     }
388     
389     template<typename ElemBlockFunc, typename Trait>
>>>     CID 1493475:    (UNCAUGHT_EXCEPT)
>>>     An exception of type "mdds::general_error" is thrown but the throw list "noexcept" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
390     multi_type_vector<ElemBlockFunc, Trait>::~multi_type_vector()
391     {
392         delete_element_blocks(0, m_block_store.positions.size());
393     }
394     
395     template<typename ElemBlockFunc, typename Trait>

** CID 1493474:  API usage errors  (SWAPPED_ARGUMENTS)


________________________________________________________________________________________________________
*** CID 1493474:  API usage errors  (SWAPPED_ARGUMENTS)
/vcl/backendtest/outputdevice/common.cxx: 940 in vcl::test::OutputDeviceTestCommon::checkOpenBezier(Bitmap &)()
934                 { { 11, 9 }, true }, { { 12, 9 }, true } };
935     
936         for (tools::Long x = 0; x < pAccess->Width(); x++)
937         {
938             for (tools::Long y = 0; y < pAccess->Height(); ++y)
939             {
>>>     CID 1493474:  API usage errors  (SWAPPED_ARGUMENTS)
>>>     The positions of arguments in the constructor for "std::pair<int, int>" do not match the ordering of the parameters:
* "y" is passed to "__x".
* "x" is passed to "__y".
940                 if (SetPixels[{ y, x }])
941                 {
942                     checkValue(pAccess, x, y, constLineColor, nNumberOfQuirks, nNumberOfErrors, true);
943                 }
944                 else
945                 {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DO7vv_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi3-2FdzQUUG1MovRf3xRkaZgxCyyjvzv5FobYta74F4W4-2BvMgGw73eXfxokyqRnkN3kFAX4DH8IkLdwfMLlfiDLL93vVB49Ej0JJdNZ-2BPDyWy7g1Q23Dq3U39F6j8k9LZCXIsujUypFJ0OZdg0zCeAFLJv8wfQhrO3aFsqlL-2BWfKhw-3D