Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1468666: Possible Control flow issues (DEADCODE) /cui/source/options/optgdlg.cxx: 766 in OfaViewTabPage::UpdateSkiaStatus()() ________________________________________________________________________________________________________ *** CID 1468666: Possible Control flow issues (DEADCODE) /cui/source/options/optgdlg.cxx: 766 in OfaViewTabPage::UpdateSkiaStatus()() 760 m_xSkiaStatusEnabled->hide(); 761 m_xSkiaStatusDisabled->hide(); 762 return; 763 } 764 765 // Easier than a custom translation string. >>> CID 1468666: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "bEnabled = SkiaHelper::isVC...". 766 bool bEnabled = SkiaHelper::isVCLSkiaEnabled(); 767 m_xSkiaStatusEnabled->set_visible(bEnabled); 768 m_xSkiaStatusDisabled->set_visible(!bEnabled); 769 770 // FIXME: should really add code to show a 'lock' icon here. 771 m_xUseSkia->set_sensitive(!officecfg::Office::Common::VCL::UseSkia::isReadOnly()); ** CID 1468665: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1468665: Null pointer dereferences (FORWARD_NULL) /sw/source/uibase/shells/textfld.cxx: 807 in SwTextShell::StateField(SfxItemSet &)() 801 else if ( !pPostItMgr->HasActiveSidebarWin() ) 802 { 803 rSet.InvalidateItem( FN_DELETE_COMMENT ); 804 rSet.InvalidateItem( FN_HIDE_NOTE ); 805 } 806 // tdf#137568 do not offer comment formating, if no comments are present >>> CID 1468665: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pPostItMgr" to "HasNotes", which dereferences it. 807 if ( !pPostItMgr->HasNotes() ) 808 rSet.DisableItem( FN_FORMAT_ALL_NOTES ); 809 } 810 break; 811 812 case FN_EDIT_FIELD: ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D2ZcC_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJieP-2F63v7J1-2F2QityukfF6pcaezW7fvxt5Yy4XXM9h0swqAkI-2BVdPvQ6YZaWuAZa8vwh4E1JZkJKIC8ltUBS3eDKy2adtP5HhBOBBEHDYVAmn7ZXmUBAiJjLqwOZv9wruJC8No2242WasWsHf9PJuwwhAGqFqjC3pY0J7sV3bOFAXasb7ZQ5mTxh-2BEfg-2BvM5Mo _______________________________________________ LibreOffice mailing list LibreOffice@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/libreoffice