On Friday 21 of February 2020, Stephan Bergmann wrote: > On 21/02/2020 11:15, Luboš Luňák wrote: > > The build is apparently incremental, so the PCH is still built > > with -DBOOST_SPIRIT_USE_OLD_NAMESPACE from a previous build. > > I think it is unfortunate that the Windows tinderbox builds can break in > such a way (currently affected are Jenkins' "Tinderbox on Master for > Windows", "Tinderbox on Master for Windows-Debug", and "Tinderbox on > Master for Win64-Debug"). > > If anybody who feels responsible for those tinderboxes or for Windows > --enable-pch in general could get that fixed, that would be appreciated. I've tried to add a gbuild rule to rebuild a PCH if its build flags change, but that's actually rather tricky - the PCH target would need to depend on a rebuild target, but the rebuild target would need the flags that are set only for the PCH target. It could possibly be handled somehow by making the rules more complicated, but I think in this case it's simpler to just do 'make clean' on the affected incremental tinderboxes. This kind of PCH breakage doesn't happen very often, or does it? -- Luboš Luňák l.lunak@xxxxxxxxxxxxx _______________________________________________ LibreOffice mailing list LibreOffice@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/libreoffice