Fwd: [ABANDONED] Remove some excessive log formatting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Just a quick query to the ML - when I’m attempting to troubleshoot issues with EMF files, I use SAL_INFO to see what records it is reading. It’s already helped me work out some issues, in particular the last one was around custom line caps.

How else should we be doing this?

Chris

Sent from my iPhone

Begin forwarded message:

From: "Stephan Bergmann (via Code Review)" <gerrit@xxxxxxxxxxxxxxxxxxxxxx>
Date: 21 November 2019 at 7:14:46 pm AEDT
To: Stephan Bergmann <sbergman@xxxxxxxxxx>
Cc: Chris Sherlock <chris.sherlock79@xxxxxxxxx>
Subject: [ABANDONED] Remove some excessive log formatting
Reply-To: sbergman@xxxxxxxxxx

Stephan Bergmann has abandoned this change. ( https://gerrit.libreoffice.org/83319 )

Change subject: Remove some excessive log formatting
......................................................................


Abandoned

I actually use the tabbing to read EMF and EMF+ files, I'd prefer
to keep this.

Hm, sounds rather like a misuse of the SAL log facility to me.  (Each use of it comes at a cost, so it shouldn't be used too lightly for anything but logging unusual events.)  Anyway, lets abandon this then.  (I had naively assumed that the formatting had been cargo-culted forward from a time when the logging in this file had been done with something other than the SAL log facility.)

--
To view, visit https://gerrit.libreoffice.org/83319
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I21e55b3430f07018bb1adebe80ef77b28011080b
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Stephan Bergmann <sbergman@xxxxxxxxxx>
Gerrit-Reviewer: Chris Sherlock <chris.sherlock79@xxxxxxxxx>
Gerrit-Reviewer: Jenkins <>
_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux