Re: Recent changes in qdisc/cls APIs

Linux Advanced Routing and Traffic Control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thomas Graf wrote:
* Andy Furniss <418A4B3E.9070801@xxxxxxxxxxxxx> 2004-11-04 15:31

Are these the only changes needed -

http://www.kernel.org/diff/diffview.cgi?file=%2Fpub%2Flinux%2Fkernel%2Fv2.6%2Ftesting%2Fpatch-2.6.10-rc1.bz2;z=2661


Yes and no. It should work, however I suggest to adapt to the new API
completely:

If you happen to have xstats:
http://people.suug.ch/~tgr/patches/accepted/gen_stats/cbq_qdisc_dump_stats.diff

If classful:
http://people.suug.ch/~tgr/patches/accepted/gen_stats/cbq_class_gen_stats.diff
http://people.suug.ch/~tgr/patches/accepted/gen_stats/cbq_class_dump_stats.diff
http://people.suug.ch/~tgr/patches/accepted/gen_stats/cbq_class_rate_est.diff

And preferely introduce requeue statistics:
http://people.suug.ch/~tgr/patches/accepted/gen_stats/requeue_stats.diff

If you happen to dump the stats yourself, remove them:
http://people.suug.ch/~tgr/patches/accepted/gen_stats/remove_bogus_qdisc_stats_copy-26.diff

As I said, I can do those changes for you if you want, it's a matter of
a few minutes for me.


Thanks for all those - I'll need time to digest them and won't be upgrading just yet.


My esfq is hacked in other ways aswell so a patch against what people really use will be better - if someone else wants to post. The iproute bit needs changing aswell for those that use the latest versions.

As for using overlimits - It was just for a test - I saw an unused counter which showed up in stats and used it for my own purpose.

I incremented it if the queue wasn't empty so I could tell if bulk traffic got into my interactive class. I'll probably get rid of it.

Andy.

_______________________________________________
LARTC mailing list / LARTC@xxxxxxxxxxxxxxx
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

[Index of Archives]     [LARTC Home Page]     [Netfilter]     [Netfilter Development]     [Network Development]     [Bugtraq]     [GCC Help]     [Yosemite News]     [Linux Kernel]     [Fedora Users]
  Powered by Linux