After further investigation I think you need the patch a little more like this for PPPoE and the params you gave (Andy do you think this looks OK?) Please let me know if this works for you.
(As near as I can tell, there is no PPP overhead(?), and you then basically encapsulate your packets in IP packets of max size 1492, with an 8 byte overhead - Perhaps Andy can correct me as to whether there is still a PPP overhead?)
I wonder if there's any easy way we can get the ATM/PPPoE support enabled at runtime. I guess a tc option would be needed to enable ADSL (atm) numbers, but the HTB qdisc should be able to detect PPP packets for PPPoE, right ? at least egress on any pppX interface.
Are you using this patch just for inbound shaping on pppX, or does it still make sense to use it on an IMQ device, or on a LAN-side ethX device to do the equivalent of ingress shaping ?
regards
-- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Damion de Soto - Software Engineer email: damion@xxxxxxxxxxxx SnapGear - A CyberGuard Company --- ph: +61 7 3435 2809 | Custom Embedded Solutions fax: +61 7 3891 3630 | and Security Appliances web: http://www.snapgear.com ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ --- Free Embedded Linux Distro at http://www.snapgear.org --- _______________________________________________ LARTC mailing list / LARTC@xxxxxxxxxxxxxxx http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/