Re: [Qemu-devel] [PATCH v2 for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14 November 2013 05:40, Stefan Weil <sw@xxxxxxxxxxx> wrote:
> If you happen to write a v3 patch, g_assert_not_reached would be even
> better than abort.
>
> It's impossible to tell why QEMU terminated after an assert without a
> debugger,
> whereas g_assert_not_reached clearly shows the location.

Maybe. I was mostly just following the pattern of existing
stub functions. Should all instances of abort() be replaced?
(g_assert_not_reached() is compile-time disablable, unlike
abort()).

-- PMM
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux