On Wed, Sep 25, 2013 at 04:22:48PM +0200, Paolo Bonzini wrote: > Il 25/09/2013 16:19, Gleb Natapov ha scritto: > >>> > > -static int nested_pf_handled(struct kvm_vcpu *vcpu) > >>> > > +static int nested_ex_handled(struct kvm_vcpu *vcpu, unsigned nr) > >>> > > { > >>> > > struct vmcs12 *vmcs12 = get_vmcs12(vcpu); > >>> > > > >>> > > - /* TODO: also check PFEC_MATCH/MASK, not just EB.PF. */ > >> > > >> > Just one more question, why drop this comment? It doesn't seem > >> > incorrect in the particular case where nr == PF_VECTOR. > > > > I moved it to vmx_inject_page_fault_nested(). > > Ah, so if you test it there, you shouldn't get here unless the > PFEC_MASK/MATCH matches. Yes, PF will never reach here in case of shadow on shadow. -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html