On 05.09.2013, at 22:21, Paul Mackerras wrote: > This adds the ability for userspace to read and write the LPCR > (Logical Partitioning Control Register) value relating to a guest > via the GET/SET_ONE_REG interface. There is only one LPCR value > for the guest, which can be accessed through any vcpu. Userspace > can only modify the following fields of the LPCR value: > > DPFD Default prefetch depth > ILE Interrupt little-endian > TC Translation control (secondary HPT hash group search disable) > > Signed-off-by: Paul Mackerras <paulus@xxxxxxxxx> There are 3 things I dislike about this patch :) 1) A vcpu one_reg should only change the state of the vcpu it's targeting. You want a vm wide thing. 2) If anyone gets crazy enough to implement HV emulation in PR KVM this would overlap with the guest's guest LPCR, so we need to name it differently. It's really VM configuration, not a register. Maybe ENABLE_CAP is a better fit? 3) Checkpatch fails: WARNING: please, no space before tabs #59: FILE: arch/powerpc/include/asm/reg.h:295: +#define LPCR_TC ^I0x00000200^I/* Translation control */$ Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
