Re: [PATCH v4 2/2] KVM: s390: use cookies for ioeventfd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il 03/07/2013 16:30, Cornelia Huck ha scritto:
> +	/*
> +	 * Return cookie in gpr 2, but don't overwrite the register if the
> +	 * diagnose will be handled by userspace.
> +	 */
> +	if (ret != -EOPNOTSUPP)
> +		vcpu->run->s.regs.gprs[2] = ret;

I think this should now be "if (ret >= 0)".

>  	/* kvm_io_bus_write returns -EOPNOTSUPP if it found no match. */

The comment is now obsolete.

>  	return ret < 0 ? ret : 0;

Otherwise looks good, thanks!

Paolo

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux