Re: [PATCH 3/3] kvm: Fix obsolete comment about locking for kvm_io_bus_read/write

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02.05.2013, at 13:00, Gleb Natapov wrote:

> On Thu, May 02, 2013 at 12:53:44PM +0200, Alexander Graf wrote:
>> 
>> On 02.05.2013, at 09:18, Gleb Natapov wrote:
>> 
>>> On Thu, May 02, 2013 at 01:24:15AM +0200, Alexander Graf wrote:
>>>> 
>>>> On 27.04.2013, at 02:53, Scott Wood wrote:
>>>> 
>>>>> Nobody is actually calling these functions with slots_lock held.
>>>>> The srcu read lock, OTOH, is required.
>>>>> 
>>>>> Signed-off-by: Scott Wood <scottwood@xxxxxxxxxxxxx>
>>>> 
>>>> Marcelo, could you please ack?
>>>> 
>>> Is something in the series depends on this patch? If not this should go
>>> directly into kvm.git, not via ppc tree.
>> 
>> If that's easier for you, I'm perfectly fine with that.
>> 
> It really is. In the case of this patch it is not a big deal of course, but it
> helps with tracking which changes an architecture code actually depends
> on, and what are just generic fixes. When fixes for the common code are
> hidden in the middle of a ppc patch set they are easy to miss. 

I agree :). That's why Scott sent the other generic patch separately. I suppose he just figured that a comment change isn't too big of a deal.


Alex

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux