On 27.04.2013, at 02:53, Scott Wood wrote: > Nobody is actually calling these functions with slots_lock held. > The srcu read lock, OTOH, is required. > > Signed-off-by: Scott Wood <scottwood@xxxxxxxxxxxxx> Marcelo, could you please ack? Alex > --- > virt/kvm/kvm_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 5da9f02..54a14fa 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -2828,7 +2828,7 @@ static int kvm_io_bus_get_first_dev(struct kvm_io_bus *bus, > return off; > } > > -/* kvm_io_bus_write - called under kvm->slots_lock */ > +/* kvm_io_bus_write - called under kvm->srcu read lock */ > int kvm_io_bus_write(struct kvm *kvm, enum kvm_bus bus_idx, gpa_t addr, > int len, const void *val) > { > @@ -2856,7 +2856,7 @@ int kvm_io_bus_write(struct kvm *kvm, enum kvm_bus bus_idx, gpa_t addr, > return -EOPNOTSUPP; > } > > -/* kvm_io_bus_read - called under kvm->slots_lock */ > +/* kvm_io_bus_read - called under kvm->srcu read lock */ > int kvm_io_bus_read(struct kvm *kvm, enum kvm_bus bus_idx, gpa_t addr, > int len, void *val) > { > -- > 1.7.10.4 > > > -- > To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html