Re: [PATCH kvm-unit-tests v2 0/4] Have x86-run parse unittests.cfg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 14.04.2013 um 20:18 hat Cole Robinson geschrieben:
> First two patches are trivial bits. Rest rewrites x86-run in python,
> which then makes it easy to parse unittests.cfg. This makes it
> simpler to invoke individual unittests the same way autotest does.
> 
> Kevin has a similar series[1], but I'm reposting this for completeness.
> 
> [1] http://www.spinics.net/lists/kvm/msg89471.html

As long as it doesn't take away functionality, it wouldn't even conflict
with my series. Unfortunately, it seems it does: The old x86-run
forwarded any additional options to the qemu binary, now there isn't any
way to specify options on the command line, but it always does its magic.

The other problem I mentioned in the other thread is that you assume
that the kernel file name and the configuration section are the same.
The test cases that exist in the configuration file with several
different argument strings are a strong hint that this assumption is
invalid.

Maybe it's really best to keep x86-run the thin wrapper that is today
and add a second script like my series does for a higher level tool.
(Though I must admit that this wasn't by design, my script was written
before x86-run existed and used to be standalone. I just called into
x86-run with this rebase to avoid duplicating things. But now it
actually seems to be the right choice, even if accidental.)

Also, Signed-off-by is missing throughout the series?

Kevin
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux