Re: [PATCH kvm-unittests v2 0/4] Add run_tests.sh script and update unittests.cfg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 14.04.2013 um 01:26 hat Cole Robinson geschrieben:
> On 04/12/2013 07:27 AM, Kevin Wolf wrote:
> > This adds a small script that allows to conveniently run all test cases and
> > that reports back one "PASS" or "FAIL" line for each test case; it also creates
> > a test.log file with the full output.
> > 
> > It parses the unittests.cfg file used by autotest, so I'm also making some
> > updates to this file and hopefully make some improvements that autotest can
> > make use of as well.
> > 
> > I checked with Lucas that adding new keys isn't a problem. One thing that is
> > likely to cause failures for autotext, though, is that I'm including i386-only
> > test cases in unittests.cfg. It should probably parse the 'arch' key in the
> > future and skip them (and possibly introduce an i386 run besides the x86_64 one
> > so that they actually get tested).
> > 
> 
> This has some overlap with a series I sent a few weeks back, enhancing x86-run
> to read unittests.cfg, and rewriting it in python for native cfg parsing and,
> cli handling, etc:
> 
> http://www.spinics.net/lists/kvm/msg88030.html
> http://www.spinics.net/lists/kvm/msg88033.html
> 
> Thread went silent though...

I don't really mind which patch is applied as long as I have an easy way
to run my tests (with my scripts, ./run_tests.sh -g tasks) and get
simple results (one line per testcase, indicating PASS or FAIL) as long
as I'm not debugging.

The problem that I see with your patch (5/5 is the interesting one,
right?) is that you mix up the kernel file name and the test name; I
don't think you can use it with something like the vmexit tests for
which several unittests.cfg sections with different options exist. And
of course, it's missing some features in comparison.

Is there some feature your Python code has that I don't have yet? I can
try to implement it then.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux