> -----Original Message----- > From: Joerg Roedel [mailto:joro@xxxxxxxxxx] > Sent: Thursday, April 11, 2013 7:57 AM > To: Yoder Stuart-B08248 > Cc: Wood Scott-B07421; kvm@xxxxxxxxxxxxxxx; qemu-devel@xxxxxxxxxx; iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx; > agraf@xxxxxxx; Bhushan Bharat-R65777 > Subject: Re: RFC: vfio API changes needed for powerpc (v3) > > On Tue, Apr 09, 2013 at 01:22:15AM +0000, Yoder Stuart-B08248 wrote: > > > What happens if a normal unmap call is done on the MSI iova? Do we > > > need a separate unmap? > > > > I was thinking a normal unmap on an MSI windows would be an error...but > > I'm not set on that. I put the msi unmap there to make things symmetric, > > a normal unmap would work as well...and then we could drop the msi unmap. > > Hmm, this API semantic isn't very clean. When you explicitly map the MSI > banks a clean API would also allow to unmap them. But that is not > possible in your design because the kernel is responsible for mapping > MSIs and you can't unmap a MSI bank that is in use by the kernel. The mapping that the vfio API creates is specific only to the assigned device. So it can be unmapped without affecting any other device... there is nothing else in the kernel making the mapping "in use". Another device in use by the kernel using the same MSI bank would have its own independent mapping. So, these mappings are not global but are device specific...just like normal DMA memory mappings. > So since the kernel owns the MSI setup anyways it should also take care > of mapping the MSI banks. What is the reason to not let the kernel > allocate the MSI banks top-down from the end of the DMA window space? > Just let userspace know (or even set if needed) in advance how many of > the windows it configures the kernel will take for mapping MSI banks and > you are fine, no? As designed the API lets user space determine the number of windows needed for MSIs, so they can be set. The only difference between what we've proposed and what you described, I think, is that the proposal allows user space to _which_ windows are used for which MSI banks. Stuart -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
