On Wed, 13 Mar 2013 20:42:41 +0800 Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxxxxxx> wrote: > >>>> How about save all mmio spte into a mmio-rmap? > >>> > >>> The problem is that other mmu code would need to care about the pointers > >>> stored in the new rmap list: when mmu_shrink zaps shadow pages for example. > >> > >> It is not hard... all the codes have been wrapped by *zap_spte*. > >> > > So are you going to send a patch? What do you think about applying this > > as temporary solution? > > Hi Gleb, > > Since it only needs small change based on this patch, I think we can directly > apply the rmap-based way. > > Takuya, could you please do this? ;) Though I'm fine with my making the patch better, I'm still thinking about the bad side of it, though. In zap_spte, don't we need to search the pointer to be removed from the global mmio-rmap list? How long can that list be? Implementing it will/may not be difficult but I'm not sure if we would get pure improvement. Unless it becomes 99% sure, I think we should first take a basic approach. What do you think? Thanks, Takuya -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
