On Thu, Feb 28, 2013 at 09:00:47AM +0200, Michael S. Tsirkin wrote: > Ignoring return value of setfsgid(gid) and setfsuid(uid) causes > warnings on F18. Check the return value: man page says > glibc returns -1 on error. > qemu-kvm is no more. It has ceased to be. Not sure what do you want me to do with the patch. > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx> > --- > fsdev/virtfs-proxy-helper.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c > index f9a8270..2f0d2b3 100644 > --- a/fsdev/virtfs-proxy-helper.c > +++ b/fsdev/virtfs-proxy-helper.c > @@ -282,6 +282,7 @@ static int send_status(int sockfd, struct iovec *iovec, int status) > */ > static int setfsugid(int uid, int gid) > { > + int ret; > /* > * We still need DAC_OVERRIDE because we don't change > * supplementary group ids, and hence may be subjected DAC rules > @@ -290,8 +291,10 @@ static int setfsugid(int uid, int gid) > CAP_DAC_OVERRIDE, > }; > > - setfsgid(gid); > - setfsuid(uid); > + ret = setfsgid(gid); > + assert(ret != -1); > + ret = setfsuid(uid); > + assert(ret != -1); > > if (uid != 0 || gid != 0) { > return do_cap_set(cap_list, ARRAY_SIZE(cap_list), 0); > -- > MST -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html