"Michael S. Tsirkin" <mst@xxxxxxxxxx> writes:
> Ignoring return value of setfsgid(gid) and setfsuid(uid) causes
> warnings on F18. Check the return value: man page says
> glibc returns -1 on error.
>
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> ---
> fsdev/virtfs-proxy-helper.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
> index f9a8270..2f0d2b3 100644
> --- a/fsdev/virtfs-proxy-helper.c
> +++ b/fsdev/virtfs-proxy-helper.c
> @@ -282,6 +282,7 @@ static int send_status(int sockfd, struct iovec *iovec, int status)
> */
> static int setfsugid(int uid, int gid)
> {
> + int ret;
> /*
> * We still need DAC_OVERRIDE because we don't change
> * supplementary group ids, and hence may be subjected DAC rules
> @@ -290,8 +291,10 @@ static int setfsugid(int uid, int gid)
> CAP_DAC_OVERRIDE,
> };
>
> - setfsgid(gid);
> - setfsuid(uid);
> + ret = setfsgid(gid);
> + assert(ret != -1);
> + ret = setfsuid(uid);
> + assert(ret != -1);
>
> if (uid != 0 || gid != 0) {
> return do_cap_set(cap_list, ARRAY_SIZE(cap_list), 0);
> --
> MST
This got fixed upstream.
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=9fd2ecdc8cb2dc1a8a7c57b6c9c60bc9947b6a73
-aneesh
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
