On Thu, Feb 21, 2013 at 03:37:16PM +0200, Nadav Har'El wrote: > On Thu, Feb 21, 2013, Jan Kiszka wrote about "Re: [PATCH] KVM: nVMX: Rework event injection and recovery": > > That generally does not help to inject/report an external IRQ to L1 as > > L1 runs with IRQs disabled around VMLAUNCH/RESUME. > > Good point, I forgot that :( > > So it looks like nested_run_pending was necessary, after all. > Not sure (as in "this is implementation detail that is possible to avoid", not as in "this check here is incorrect!" :)). If interrupts are disabled then vmx_interrupt_allowed() should return false because interrupts are disabled, not because we emulating guest entry. This is easier said that done though, but I'll think about it. Looks like SVM does it this way. -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html