On Fri, 16 Nov 2012, Will Deacon wrote: > > I'm seeing the following breakage with this patch applied: > > > > [penberg@tux kvm]$ make > > CC hw/rtc.o > > CC ioport.o > > CC kvm-cpu.o > > CC kvm.o > > In file included from include/kvm/rbtree-interval.h:4:0, > > from include/kvm/ioport.h:4, > > from hw/rtc.c:3: > > ../../include/linux/rbtree_augmented.h:125:24: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘void’ > > In file included from include/kvm/rbtree-interval.h:4:0, > > from include/kvm/ioport.h:4, > > from ioport.c:1: > > ../../include/linux/rbtree_augmented.h:125:24: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘void’ > > make: *** [hw/rtc.o] Error 1 > > make: *** Waiting for unfinished jobs.... > > make: *** [ioport.o] Error 1 > > I'm struggling to reproduce this with my tree. Can you confirm whether or > not you have commit 29fc7c5a4f51 ("rbtree: include linux/compiler.h for > definition of __always_inline") in your *kernel* sources please? No, I don't. I can cherry-pick that to my tree if necessary. Pekka