On 10/29/2012 11:18 PM, Will Auld wrote:
> In order to track who initiated the call (host or guest) to modify an msr
> value I have changed function call parameters along the call path. The
> specific change is to add a struct pointer parameter that points to (index,
> data, caller) information rather than having this information passed as
> individual parameters.
>
> The initial use for this capability is for updating the IA32_TSC_ADJUST
> msr while setting the tsc value. It is anticipated that this capability
> is useful for other tasks.
Looks good.
>
> struct x86_instruction_info;
>
> +/*
> + * Defined values for msr_data.initiated_by
> + */
> +#define KVM_GUEST_INITIATED 0x1
> +#define KVM_HOST_INITIATED 0x2
> +
> +struct msr_data {
> + u32 initiated_by;
But this can be simplified to 'bool host_initiated;'. Later checks
should look cleaner.
> + u32 index;
> + u64 data;
> +};
> +
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
