On 09/15/2012 11:13 PM, Marcelo Tosatti wrote:
> On Fri, Sep 14, 2012 at 05:57:22PM +0800, Xiao Guangrong wrote:
>> We can not directly call kvm_release_pfn_clean to release the pfn
>> since we can meet noslot pfn which is used to cache mmio info into
>> spte
>>
>> Signed-off-by: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxxxxxx>
>> ---
>> arch/x86/kvm/mmu.c | 6 ++++--
>> arch/x86/kvm/paging_tmpl.h | 6 ++++--
>> 2 files changed, 8 insertions(+), 4 deletions(-)
>
> Its clearer to the reader if is_invalid_pfn() is used instead of
> is_error_pfn.
>
> BTW how about killing this unused helper
>
> static bool mmu_invalid_pfn(pfn_t pfn)
> {
> return unlikely(is_invalid_pfn(pfn));
> }
>
> This can be done inlined.
Okay, will do. Thanks Marcelo!
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
