On 09/16/2012 08:07 PM, Avi Kivity wrote: > Instead of branchy code depending on level, gpte.ps, and mmu configuration, > prepare everything in a bitmap during mode changes and look it up during > runtime. > Avi, Can we introduce ignore_bits_mask[] (like rsvd_bits_mask), if pse is not supported, we can set PTE_PSE in this ignore_bits_mask, then the function can be simplified to return (level == 1) || gpte & ~vcpu->ignore_bits_mask[level] & PTE_PSE I think it is more readable. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html