On Tue, Sep 4, 2012 at 9:28 PM, Michael S. Tsirkin <mst@xxxxxxxxxx> wrote: > On Tue, Sep 04, 2012 at 07:27:32PM +0000, Blue Swirl wrote: >> On Tue, Sep 4, 2012 at 8:32 AM, Avi Kivity <avi@xxxxxxxxxx> wrote: >> > On 09/03/2012 10:32 PM, Blue Swirl wrote: >> >> On Mon, Sep 3, 2012 at 4:14 PM, Avi Kivity <avi@xxxxxxxxxx> wrote: >> >>> On 08/29/2012 11:27 AM, Markus Armbruster wrote: >> >>>> >> >>>> I don't see a point in making contributors avoid non-problems that might >> >>>> conceivably become trivial problems some day. Especially when there's >> >>>> no automated help with the avoiding. >> >>> >> >>> -Wpointer-arith >> >> >> >> +1 >> > >> > FWIW, I'm not in favour of enabling it, just pointing out that it >> > exists. In general I prefer avoiding unnecessary use of extensions, but >> > in this case the extension is trivial and improves readability. >> >> Void pointers are not so type safe as uint8_t pointers. > > casts are even worse. > >> There's also >> little difference in readability between those in my opinion. > > here too, casts are worse for readability. I agree they are bad in both accounts, but in most cases it is possible to use different types consistently (like uint8_t * or char * instead of void *) without adding casts. > >> > >> > >> > -- >> > error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
