Re: [PATCH] kvm/fpu: Enable fully eager restore kvm FPU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/20/2012 12:24 PM, Roedel, Joerg wrote:
> (Back from vacation)
> 
> On Thu, Aug 16, 2012 at 01:59:02PM +0300, Avi Kivity wrote:
>> Ok.  Please check that ~KVM_XSTATE_LAZY expands to 64-bits correctly,
>> maybe we need to cast it to u64 before negating it.
>> 
>> Note that we limit xcr0 to the bits allowed by the host, so the currect
>> kernel is safe even on hardware with state that isn't tracked by cr0.ts.
>>  But it's better to be safe here.
>> 
>> Joerg, IIRC LWP uses one of these bits?  Should it be added to the mask?
> 
> LWP uses bit 62 in xcr0 and is not tracked by cr0.ts either. So this bit
> should be used to the mask too (in other words LWP is a non-lazy state).

So it was broken all along?  Yikes.


-- 
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux