Re: [PATCH] kvm/fpu: Enable fully eager restore kvm FPU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



(Back from vacation)

On Thu, Aug 16, 2012 at 01:59:02PM +0300, Avi Kivity wrote:
> Ok.  Please check that ~KVM_XSTATE_LAZY expands to 64-bits correctly,
> maybe we need to cast it to u64 before negating it.
> 
> Note that we limit xcr0 to the bits allowed by the host, so the currect
> kernel is safe even on hardware with state that isn't tracked by cr0.ts.
>  But it's better to be safe here.
> 
> Joerg, IIRC LWP uses one of these bits?  Should it be added to the mask?

LWP uses bit 62 in xcr0 and is not tracked by cr0.ts either. So this bit
should be used to the mask too (in other words LWP is a non-lazy state).

Regards,

	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux