On Mon, Aug 13, 2012 at 6:31 AM, Michael Ellerman <michael@xxxxxxxxxxxxxx> wrote: >> > diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c >> > index a36bd00..9e5c1d4 100644 >> > --- a/tools/kvm/builtin-run.c >> > +++ b/tools/kvm/builtin-run.c >> > @@ -257,7 +257,8 @@ static int set_net_param(struct virtio_net_params *p, const char *param, >> > p->vhost = atoi(val); >> > } else if (strcmp(param, "fd") == 0) { >> > p->fd = atoi(val); >> > - } >> > + } else >> > + die("Unknown network parameter %s", param); >> >> we need braces here: > > We don't _need_ braces, but I assume you mean you'd prefer braces? This is Linux coding style so we don't prefer them either. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html