On Sat, 2012-08-11 at 08:21 +0800, Asias He wrote:
> On Fri, Aug 10, 2012 at 1:38 PM, Michael Ellerman
> <michael@xxxxxxxxxxxxxx> wrote:
> > Currently the parsing of network command line parameters doesn't check
> > for unknown parameters.
> >
> > For example "-n mod=none" will cause kvmtool to setup TAP networking.
> >
> > Save users from their typos by checking for unknown parameters and bailing.
> >
> > Signed-off-by: Michael Ellerman <michael@xxxxxxxxxxxxxx>
> > ---
> > tools/kvm/builtin-run.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c
> > index a36bd00..9e5c1d4 100644
> > --- a/tools/kvm/builtin-run.c
> > +++ b/tools/kvm/builtin-run.c
> > @@ -257,7 +257,8 @@ static int set_net_param(struct virtio_net_params *p, const char *param,
> > p->vhost = atoi(val);
> > } else if (strcmp(param, "fd") == 0) {
> > p->fd = atoi(val);
> > - }
> > + } else
> > + die("Unknown network parameter %s", param);
>
> we need braces here:
We don't _need_ braces, but I assume you mean you'd prefer braces?
cheers
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
