On 06/19/2012 01:20 AM, Christoffer Dall wrote: > On Mon, Jun 18, 2012 at 9:45 AM, Avi Kivity <avi@xxxxxxxxxx> wrote: >> On 06/15/2012 10:09 PM, Christoffer Dall wrote: >>> From: Christoffer Dall <cdall@xxxxxxxxxxxxxxx> >>> >>> Handles the guest faults in KVM by mapping in corresponding user pages >>> in the 2nd stage page tables. >>> >>> Introduces new ARM-specific kernel memory types, PAGE_KVM_GUEST and >>> pgprot_guest variables used to map 2nd stage memory for KVM guests. >>> >>> Leverages MMU notifiers on KVM/ARM by supporting the kvm_unmap_hva() operation, >>> where we remove the HVA from the 2nd stage translation. All other KVM MMU >>> notifierhooks are NOPs. >> >> I think you must at least support change_pte (possibly by unmapping). >> Andrea? >> > hmmm, at least for KSM support we need to support change_pte (are > there other callers for this type of memory?) > > It's not trivial I guess, since we would need to support COW and > thereby stage-2 permission faults... Marc, right? As I mentioned, you can support change_pte by unmapping. This will cause ksm to be ineffective (pages will only be shared if the guest doesn't touch them at all), but it's enough to get started. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html