On Thu, May 31, 2012 at 01:15:13PM +0300, Gleb Natapov wrote: > > > > + /* Cache not set: safe but we don't bother. */ > > > > + unlikely(apic->isr_cache == -1) || > > > > + /* Need EOI to update ioapic. */ > > > > + unlikely(kvm_ioapic_handles_vector(vcpu->kvm, apic->isr_cache))) > > > > + return; > > > > + > > > > + pv_eoi_set_pending(apic->vcpu); > > > > +} > > > > + > > > apic_sync_pv_eoi_to_guest() is not paired with > > > apic_sync_pv_eoi_from_guest() if event injection is canceled. > > > You can enter guest with stale pv_eoi bit. > > > > Never. The pv_eoi bit is cleared on each exit. > There will be no exit since there will be no entry. Search for > "goto out" after kvm_lapic_sync_to_vapic(). I think you've found a bug, thanks a bunch. I have fixed it but the x86 guys asked me not to post more patches until merge window closes :( So I'll sit on a fix for several days. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
