On Tue, 2012-01-31 at 14:45 +0200, Avi Kivity wrote:
> On 01/28/2012 04:21 PM, Alex Williamson wrote:
> > Stop using compatibility mode and at the same time fix available
> > access sizes. The PCI spec indicates that the MSI-X table may
> > only be accessed as DWORD or QWORD.
> >
> >
> > static const MemoryRegionOps msix_mmio_ops = {
> > - .old_mmio = {
> > - .read = { msix_mmio_readb, msix_mmio_readw, msix_mmio_readl, },
> > - .write = { msix_mmio_writeb, msix_mmio_writew, msix_mmio_writel, },
> > - },
> > + .read = msix_mmio_read,
> > + .write = msix_mmio_write,
> > .endianness = DEVICE_NATIVE_ENDIAN,
> > + .impl = {
> > + .min_access_size = 4,
> > + .max_access_size = 8,
> > + },
> > };
> >
>
> .impl.min_access_size = 4 means the core will convert 1-byte I/O to
> 4-byte I/O (using rmw if needed). That's not what we want, I think you
> can leave it at 1 and explicitly ignore small accesses in the callbacks.
>
> Have you tested 8-byte I/O? This is the first user. Don't you need to
> set .valid.max_access_size?
I have not explicitly tested 8-byte I/O, figured it might just work.
Hmm, I wonder if we really need to be strict enough to reject byte and
word access. It doesn't follow the spec, but I don't know that it buys
us anything to be strict about it. Anyway, I'll look at .valid and
respin. Thanks,
Alex
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
