Re: [PATCH] kvm tools: Use assert() helper to check a variable value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:
On Mon, Dec 19, 2011 at 11:40:09AM +0100, Ingo Molnar wrote:

GDB will catch that signal.


Yeah, good point! Pekka, drop this patch please, I'll make new one at evening.

On Mon, 19 Dec 2011, Ingo Molnar wrote:
Patch is good as-is IMO - assert() was used before so it's not a
regression per se.

Acked-by: Ingo Molnar <mingo@xxxxxxx>

The tool-specific BUG() implementation can be added as a delta
on top of that. It's in fact better to keep those two steps
separate.

Agreed. Cyrill, please make it an incremental patch on top of this one.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux