Re: [PATCH] kvm tools: Use assert() helper to check a variable value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 19, 2011 at 09:13:28AM +0200, Pekka Enberg wrote:
>> >
>> >-    BUILD_BUG_ON(i > E820_X_MAX);
>> >+    assert(i <= E820_X_MAX);
>>
>> We should use BUG_ON() like tools/perf does.

On Mon, Dec 19, 2011 at 9:57 AM, Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:
> We dont have it yet. So I'll introduce this helper later,
> but note that we will have to cover _all_ assert() calls then,
> so it's better to make in a separate patch. Meanwhile such fix
> it better than bug ;)

You don't need to convert all of them at the same time but we're not
adding new assert() calls.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux