Re: [PATCH 05/28] kvm tools: 64-bit tidy; use PRIx64 when printf'ing u64s and link appropriately

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/12/11 16:49, Ingo Molnar wrote:
> 
> * Matt Evans <matt@xxxxxxxxxx> wrote:
> 
>> Since tools/kvm/include/linux/types.h only requires __u32, 
>> __u64 et al from <asm/types.h>, wouldn't it be most 
>> straightforward to just #include <asm-generic/int-ll64.h>?  
>> This avoids #define __KERNEL__ breaking other includes brought 
>> into userland, avoids changing system headers/distros, and 
>> includes the file we're really interested in on both x86 & 
>> PPC.
> 
> No system headers need to be changed: you can just patch 
> powerpc/types.h with the extra __SANE_USERSPACE__ define (or any 
> suitable name) and the KVM tool should work as-is.
> 
> The beauty of tools/kvm/ being integrated into the kernel tree.
> 
> Really, if that works and if the PowerPC folks agree then we 
> have an immediate, fully adequate, instantly applicable 
> solution.

Ahh, I finally understand you-- I'd earlier thought you were referring to the
system headers' asm/types.h, etc.  Thanks for your patience on this very trivial
point :-)  I'll add __SANE_USERSPACE_TYPES__ and we'll see how the others like
it. >:)  (Paul, that sound OK?)


Thanks,


Matt
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux