On Wed, 2011-11-30 at 09:34 -0800, Greg Rose wrote: > On 11/29/2011 9:19 AM, Ben Hutchings wrote: > > On Tue, 2011-11-29 at 16:35 +0000, Ben Hutchings wrote: > >> > >> Maybe I missed something! [...] > >> If not, please explain what the new model *is*. > > The new model is to incorporate a VEB into the NIC. The current model > doesn't address any of the requirements of a VEB in the NIC and this > proposed set of patches allow us to set MAC filters for the *ports* on > the internal NIC VEB. Consider the PF and each of the VFs as just a > port on the VEB. We need the ability to set L2 filters (MAC, MC and > VLAN) for each of the ports on that VEB. There is no currently > supported method for doing this. So yes, this is a new model although > it's a fairly simple one. Explain precisely how the VEB changes the existing model. Explain how the existing MAC filter and VF filter APIs interact with port filters on the VEB. Refer to any relevant standards. (I have really had enough of net driver API proposals where all the difficult questions are punted to the implementation. Either implementations diverge and users and userspace developers are left horribly confused, or else the second and subsequent implementations have to follow whatever quirks the first implementation had. It's an essential part of the review process that such questions are asked and answered.) Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
