On 2011-10-18 13:06, Michael S. Tsirkin wrote: > On Tue, Oct 18, 2011 at 09:50:50AM +0200, Jan Kiszka wrote: >> If MSI-X is disabled or the global mask is set, don't fire the notifier >> during registration or removal, reporting a wrong state. >> >> Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx> > > Hmm. Could you please describe how does one trigger the incorrect behaviour? > Looking at the upstream code, I notice that msix_notify_if_unmasked > already calls msix_is_masked which checks the function mask. And it > also checks msix_entry_used which, ATM, is only set when msix is > enabled. Right, that's not yet an issue. Will be required when we get rid of used vector tracking. Will adjust the commit log accordingly and move it back into that context. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
