On 2011-10-17 15:43, Michael S. Tsirkin wrote: > On Mon, Oct 17, 2011 at 11:27:45AM +0200, Jan Kiszka wrote: >> diff --git a/hw/msi.c b/hw/msi.c >> index 3c7ebc3..9055155 100644 >> --- a/hw/msi.c >> +++ b/hw/msi.c >> @@ -40,6 +40,14 @@ >> /* Flag for interrupt controller to declare MSI/MSI-X support */ >> bool msi_supported; >> >> +static void msi_unsupported(MSIMessage *msg) >> +{ >> + /* If we get here, the board failed to register a delivery handler. */ >> + abort(); >> +} >> + >> +void (*msi_deliver)(MSIMessage *msg) = msi_unsupported; >> + > > How about we set this to NULL, and check it instead of the bool > flag? > Yeah. I will introduce bool msi_supported(void) { return msi_deliver != msi_unsupported; } OK? Jan
Attachment:
signature.asc
Description: OpenPGP digital signature