On Mon, 2011-10-03 at 21:05 +0200, Michael S. Tsirkin wrote: > I thought about this some more. If length was too large host is > right now writing into pages that we have freed. > That is very bad, and I don't know what do do with it, > really not worth prettifying that IMO, NULL pointer is the least of our > worries. > > But, with mergeable buffers at least, and that is the main mode anyway, > there is always a single page per buf, right? > So I think we should change the code, > and for mergeable buffers we shall only verify that > length <= PAGE_SIZE. In receive_mergeable() we already verify both 'page' being non-null and length: if (len > PAGE_SIZE) len = PAGE_SIZE; > > IOW copy a bit of code from page_to_skb(vi, page, len) > to receive_mergeable, maybe add a common function > if we need to avoid duplication. -- Sasha. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
