On Wed, Aug 17, 2011 at 6:14 PM, walimis <walimisdev@xxxxxxxxx> wrote: > On Wed, Aug 17, 2011 at 03:02:55PM +0300, Sasha Levin wrote: >>On Wed, Aug 17, 2011 at 2:44 PM, Pekka Enberg <penberg@xxxxxxxxxx> wrote: >>> On 8/17/11 12:44 PM, Liming Wang wrote: >>>> >>>> Becasue virtio random generator is a single device, change its option >>>> type to boolean. >>>> >>>> Signed-off-by: Liming Wang<walimisdev@xxxxxxxxx> >>> >>> I suppose the idea here was to support multiple rng devices. Sasha? >> >>I wrote the idea behind supporting multiple rng devices in the commit >>message of that patch: >> >>Since multiple hardware rng devices of the same type are currently >>unsupported by the kernel, this serves more as an example of a basic >>virtio driver under kvm tools and can be used to debug the PCI layer. >> >>Currently I use it mostly to easily test the virtio-pci and related >>code, for example - when I added MSI-X I've tried creating a bunch of >>virtio-rng devices and seeing how the kernel handles them. > I see. > I found this issue because kvm tools crashed when I used multiple rng devices > to test. virtio-rng itself wasn't written to support multiple devices either, what you see when you cat /dev/hwrng with more than one device is the guest driver hitting a BUG(). Execution should resume within the guest. kvm tools is innocent :) -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
