On Wed, Aug 17, 2011 at 03:02:55PM +0300, Sasha Levin wrote: >On Wed, Aug 17, 2011 at 2:44 PM, Pekka Enberg <penberg@xxxxxxxxxx> wrote: >> On 8/17/11 12:44 PM, Liming Wang wrote: >>> >>> Becasue virtio random generator is a single device, change its option >>> type to boolean. >>> >>> Signed-off-by: Liming Wang<walimisdev@xxxxxxxxx> >> >> I suppose the idea here was to support multiple rng devices. Sasha? > >I wrote the idea behind supporting multiple rng devices in the commit >message of that patch: > >Since multiple hardware rng devices of the same type are currently >unsupported by the kernel, this serves more as an example of a basic >virtio driver under kvm tools and can be used to debug the PCI layer. > >Currently I use it mostly to easily test the virtio-pci and related >code, for example - when I added MSI-X I've tried creating a bunch of >virtio-rng devices and seeing how the kernel handles them. I see. I found this issue because kvm tools crashed when I used multiple rng devices to test. > >Since it having multiple virtio-rng devices doesn't really do anything >in the guest at the moment it could also be removed (unless we fix the >kernel to support them :) ). > >IMO this can go either way, theres no reason to keep support for >multiple devices besides making development a bit easier. OK, as you said, we can keep it for development. walimis -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
