I don't know if there were any other drivers for this patch, but it along with another patch (maybe integrated elsewhere for 32bit BAR vs 8bit) certainly helped me out a lot. These patches fixed ioremap errors I was seeing (I had a 16MB PCI memory region, but it appeared to be only 256 bytes in size; the kernel complained bitterly about that on ioremap). It also was an issue of expected vs unexpected output from lspci -vvv. I'm working on my out-of-tree PCI driver to see if it can become in tree. I have more cleanup to do, and seeing how close I can come to the target coding standards. \dae On Wed, Aug 10, 2011 at 09:13:35AM +0300, Pekka Enberg wrote: > On 8/9/11 7:46 PM, Avi Kivity wrote: > >On 08/09/2011 06:39 PM, Ingo Molnar wrote: > >>* Sasha Levin<levinsasha928@xxxxxxxxx> wrote: > >> > >>> This patch makes BAR 1 16k, instead of BAR0 - which is the PIO bar. > >>> > >> > >>This changelog is missing some key information: > >> > >> - how did you find the bug (by chance via code review or did you see > >> some actual badness?) > >> > >> - what practical effect (if any) did you see from this patch? > >> > >> - what practical effect (if any) do you expect others to see > >>from this patch? > >> > >>I suspect this patch is only for completeness/correctness but has no > >>practical effect - but that's a guess. > >> > > > >My guess would be that seabios tried to lay out the BARs and had > >trouble fitting a 16k pio bar in the small PCI pio region. > > Sasha? IIRC this fixed some issue with David's out-of-tree PCI driver? -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
