Re: [PATCH] kvm tools: Use correct size for VESA memory BAR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/9/11 7:46 PM, Avi Kivity wrote:
On 08/09/2011 06:39 PM, Ingo Molnar wrote:
* Sasha Levin<levinsasha928@xxxxxxxxx>  wrote:

>  This patch makes BAR 1 16k, instead of BAR0 - which is the PIO bar.
>

This changelog is missing some key information:

  - how did you find the bug (by chance via code review or did you see
    some actual badness?)

  - what practical effect (if any) did you see from this patch?

- what practical effect (if any) do you expect others to see from this patch?

I suspect this patch is only for completeness/correctness but has no
practical effect - but that's a guess.


My guess would be that seabios tried to lay out the BARs and had trouble fitting a 16k pio bar in the small PCI pio region.

Sasha? IIRC this fixed some issue with David's out-of-tree PCI driver?
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux