* Asias He <asias.hejun@xxxxxxxxx> wrote: > > I don't care too much what we use as the namespace prefix but as > > a directory name tools/kvm/uip is pretty meaningless. I'd just > > move the code under tools/kvm/net to mirror what the kernel > > already has. > > I have thought about putting user mode net code in tools/kvm/net. > However, we have net code in tools/kvm/virtio as well. Is this a > problem in terms of clean code organization? > > And I think splitting the tap code in virtio/net.c into > tools/kvm/net is a good idea. Further, we can put macvtap related > code into tools/kvm/net as well. Well, tools/kvm/net/ is for all things networking - one component of which is the Ethernet transport layer (a vring based driver), which can then branch in two directions: go straight to a host-side ethernet transport facility (TUN device) or can be streamed via TCP sockets (unet). If we want to structure it more we may want to have tools/kvm/net/guest/ [handling packets to/from the guest], tools/kvm/net/host/ [handling packets to/from the host], etc. There's 3 conceptual layers here: the guest, the hypervisor and the host. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html