On 07/02/2011 04:36 AM, Pekka Enberg wrote:
> On Fri, Jul 1, 2011 at 7:50 PM, Stefan Hajnoczi <stefanha@xxxxxxxxx> wrote:
>> On Fri, Jul 1, 2011 at 12:38 AM, Asias He <asias.hejun@xxxxxxxxx> wrote:
>>> On 06/30/2011 04:56 PM, Stefan Hajnoczi wrote:
>>>> On Thu, Jun 30, 2011 at 9:40 AM, Asias He <asias.hejun@xxxxxxxxx> wrote:
>>>>> uip stands for user mode {TCP,UDP}/IP. Currently, uip supports ARP, ICMP,
>>>>> IPV4, UDP, TCP. So any network protocols above UDP/TCP should work as well,
>>>>> e.g., HTTP, FTP, SSH, DNS.
>>>>
>>>> There is an existing uIP which might cause confusion, not sure if
>>>> you've seen it. First I thought you were using that :).
>>>
>>> I heard about uIP, but this patchset have nothing to do with uIP ;-)
>>>
>>> At first I was naming the user mode network as "UNET" which is User mode
>>> NETwork, however, I though uip looks better because it is shorter.
>>>
>>> Anyway, if uip do cause confusion. I'd like to change this naming.
>>
>> It's up to you but now is the right time to do it. Consider if
>> another program wants to reuse this code or if you ever want to make
>> it a library, it wouldn't help to have a confusing name.
>
> I don't care too much what we use as the namespace prefix but as a
> directory name tools/kvm/uip is pretty meaningless. I'd just move the
> code under tools/kvm/net to mirror what the kernel already has.
>
I have thought about putting user mode net code in tools/kvm/net.
However, we have net code in tools/kvm/virtio as well. Is this a problem
in terms of clean code organization?
And I think splitting the tap code in virtio/net.c into tools/kvm/net is
a good idea. Further, we can put macvtap related code into tools/kvm/net
as well.
--
Best Regards,
Asias He
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
