* Sasha Levin <levinsasha928@xxxxxxxxx> wrote: > On Tue, 2011-05-17 at 09:41 +0200, Ingo Molnar wrote: > > * Sasha Levin <levinsasha928@xxxxxxxxx> wrote: > > > +#include <kvm/interval-rbtree.h> > > > +#include <stdio.h> > > > +#include <stdlib.h> > > > > At first sight i dont think you really need the stdio.h and stlib.h includes - > > you added these while having debugging printfs in the code? > > We can drop either of them, but not both. Added it for size_t > definition. Oh, ok - sure! > > So the rb-node iterator is named 'new', while the rb-int-node iterator is > > called 'this'? That does not make sense. > > I actually took that bit from an example in Documentation/rbtree.txt of how > to write an insertion function :) The kernel is far from perfect :-) > Maybe it's worth doing another rbtree.txt patch and cleaning up the samples > there? Yeah :-) Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
