On Sun, 2011-05-08 at 20:34 +0300, Pekka Enberg wrote: > On Sun, May 8, 2011 at 8:29 PM, Sasha Levin <levinsasha928@xxxxxxxxx> wrote: > > On Sun, 2011-05-08 at 20:28 +0300, Pekka Enberg wrote: > >> On Sun, May 8, 2011 at 8:21 PM, Sasha Levin <levinsasha928@xxxxxxxxx> wrote: > >> > I'm seeing no more hangs, but why enable it unconditionally? > >> > Maybe enable it by default, but we shouldn't force the activation of > >> > virtio modules if the user doesn't want them. > >> > >> I meant enabling the device on PCI bus like we did before. > > > > Thats what I've meant too. virtio-console is the only device which got > > initialized even if it wasn't requested (even when '-c serial' was > > passed specifically). > > The more options we have, the more combinations we need to test. > What's the downside of enabling virtio console by default? The upside > is that it's less likely to break. Btw, we should probably do that for > virtio rng as well. I fully support enabling it by default, I'm against enabling it even if the user asked to have it disabled. -- Sasha. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
