Re: [PATCH v2 4/4] kvm tools: Fix virtio console hangs by removing IRQ injection for tx path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2011-05-08 at 21:09 +0800, Asias He wrote:
> As virtio spec says:
> 
> """
>  Because this is high importance and low bandwidth, the current Linux
>  implementation polls for the buffer to be used, rather than waiting
>  for an interrupt, simplifying the implementation signicantly.
> """
> 
> drivers/char/virtio_console.c
>  send_buf() {
>  ...
> 	/* Tell Host to go! */
> 	virtqueue_kick(out_vq);
>  ...
>         while (!virtqueue_get_buf(out_vq, &len))
>                 cpu_relax();
>  ...
>  }
> 
> The console hangs can simply be reproduced by yes command which
> gives tremendous console IOs and IRQs.

Sasha, does this fix the hangs you were seeing? We should re-enable
virtio console unconditionally if this does - that increases test
coverage for virtio console.

			Pekka

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux