On 05/05/2011 01:36 PM, Jan Kiszka wrote:
> > The problem is with hardware MSRs (PV MSRs are protected by cpuid, and > always disable themselves when zeroed). Well, this doesn't change the problem of the existing code.
Right.
> > What I suggested wasn't zeroing them, but writing the value we read just > after vcpu creation. > > We had a regression when we started supporting PAT. Zeroing it causes > the cache to be disabled, making everything ridiculously slow. We now > special case it; my proposed solution would have taken care of it. I'm talking about the current code, not the proper way to do it in the future. PAT demonstrates why regressions can happen as long as we zero and it's better to stop this now even without the new code in place.
I'm not sure, but if we do adopt the new reset mechanism, it doesn't matter. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
