On Thu, 2011-05-05 at 10:52 +0300, Pekka Enberg wrote: > On Thu, May 5, 2011 at 10:47 AM, Ingo Molnar <mingo@xxxxxxx> wrote: > >> > The build fails here too, in a similar way, on a 32-bit Fedora 14 box. > >> > >> Curious. It works fine on my box. I think it's missing #include > >> <asm/bitsperlong.h>. I wonder why system.h isn't pulling that > >> itself... > > > > asm/system.h is one of the messier kernel headers, so i'm not surprised it has > > assymetric requirements on 64-bit and 32-bit systems. > > So does including <asm/bitsperlong.h> before <asm/system.h> fix the > problem on 32-bit boxes? If so, I'd prefer we fix it like that for > now. > > > We could fix it (provide those dependencies), or we could pick > > tools/perf/perf.h's mb() definitions. That's much cruder than the nice kernel > > memory barriers though ... > > That's the second best option, I think. I agree with Pekka, For the same reasons we provided the dependencies for including <linux/list.h> instead of just taking the source. -- Sasha. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
